-
-
Notifications
You must be signed in to change notification settings - Fork 432
[litellm] Display model IDs to match search string #1445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: litellm
Are you sure you want to change the base?
Conversation
Thank you for starting this Sanjiv. I was able to reproduce the bug you are reporting. I tried using the ![]() In addition to using the
None of these fixed the bug. Over my entire history of working on JAI, I've cumulatively spent at least 15 hours trying to get Autocomplete components working. The conclusion I've arrived at is that the MUI Autocomplete component just doesn't work. |
@srdas If you're up for it, I think the next best step is to re-implement the The MUI Docs: https://mui.com/material-ui/react-menu/#positioned-menu |
Sure, I'll work on this. |
@dlqqq Thanks for the ideas above, based on which I have updated this PR. Given that there are thousands of models available on LiteLLM, I changed the If the search string fails to find a match then the model-input.mov |
@srdas This is a clever way of reducing the performance impact incurred filtering & sorting a list of up to 1000 entries. However, requiring a user to click to show suggestions is less intuitive than showing suggestions automatically. Users will expect search bars to show suggestions automatically like Google/Bing. When building interfaces, it is generally good to "minimize surprise" and align our UIs with what an average user would expect. I recommend building an automatic suggestion UI first and optimizing for performance later. |
Fixes #1428
Screen.Recording.2025-08-08.at.6.41.25.AM.mov